Improve validation of URLPathTemplate
and JSONSelection
strings passed to @source{Type,Field}
directives
#2926
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2910.
This work is not finished because we ultimately want to validate that the variables used by
URLPathTemplate
strings and the output shapes ofJSONSelection
strings match the available field and argument names.This PR adds parsers for the two syntaxes and tests of those parsers, which allows us to validate the strings have the expected syntax, even if we're not validating semantics yet.
As another
TODO
, when we useJSONSelection
forbody
parameters, it's the input shape of the selection that needs to be validated, rather than the output shape, sogetSelectionOutputShape
may not be sufficient.