Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix module load order within internals-js/src/specs directory using index.ts module #2924

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix module load order within internals-js/src/specs directory using index.ts module #2924

wants to merge 5 commits into from

Commits on Feb 1, 2024

  1. Test file that triggers module import order problems.

    @benjamn
    benjamn committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    cd9a220 View commit details
    Browse the repository at this point in the history

  2. Fix module load order problems by creating specs/index.ts file. 

    https://medium.com/visual-development/how-to-fix-nasty-circular-dependency-issues-once-and-for-all-in-javascript-typescript-a04c987cf0de
    @benjamn
    benjamn committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    a247374 View commit details
    Browse the repository at this point in the history

  3. Avoid circular import { federationMetadata } from "../federation" i… 

    …n `federationSpec.ts`.

By storing `schema._federationMetadata` as a typed private property of
`Schema`, we can access it using the `schema['_federationMetadata']`
syntax in places where we don't want to import the `federationMetadata`
helper function, since doing so also imports the whole `federation.ts`
module, leading to dependency cycles.
    @benjamn
    benjamn committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    5416e49 View commit details
    Browse the repository at this point in the history

  4. Move federationMetadata function to definitions.ts.

    @benjamn
    benjamn committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    292e288 View commit details
    Browse the repository at this point in the history

  5. Add changeset

    @benjamn
    benjamn committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    f02243e View commit details
    Browse the repository at this point in the history