Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graphql versions, remove codegen and cruft (v3) #2617

Open
wants to merge 5 commits into
base: version-3
Choose a base branch
from

Conversation

trevor-scheer
Copy link
Member

Updating the graphql versions turned into whack-a-mole. Unfortunately, TS won't build and tests won't run until this happens so...this all happens now and in a larger chunk than I'd like.

Some of the notable changes that had to happen after updating graphql versions to 15 || 16:

  • Deleted apollo-graphql exports (which now live in @apollo/subgraph anyway)
  • Deleted codegen due to various graphql version incompatibilities. This could be undone and issues resolved if necessary.
  • The apollo-link versions in use here weren't compatible with new versions of graphql. Their equivalents in current versions of @apollo/client came with TS usability challenges w.r.t. dom / fetch global typings. I replaced with graphql-request.
  • Removed @apollographql/graphql-language-service fork usages, using the original package from the graphiql repo 🥳

@changeset-bot
Copy link

changeset-bot bot commented May 9, 2022

⚠️ No Changeset found

Latest commit: 6039962

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 9, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant