Incubating WebSocketNetworkTransport #5362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
BoD
reviewed
Nov 9, 2023
libraries/apollo-websocket-network-transport-incubating/build.gradle.kts
Outdated
Show resolved
Hide resolved
...ating/src/commonMain/kotlin/com/apollographql/apollo3/network/websocket/AppSyncWsProtocol.kt
Show resolved
Hide resolved
...ating/src/commonMain/kotlin/com/apollographql/apollo3/network/websocket/GraphQLWsProtocol.kt
Show resolved
Hide resolved
.../src/commonMain/kotlin/com/apollographql/apollo3/network/websocket/SubscriptionWsProtocol.kt
Show resolved
Hide resolved
.../src/commonMain/kotlin/com/apollographql/apollo3/network/websocket/SubscriptionWsProtocol.kt
Outdated
Show resolved
Hide resolved
...c/commonMain/kotlin/com/apollographql/apollo3/network/websocket/WebSocketNetworkTransport.kt
Outdated
Show resolved
Hide resolved
...c/commonMain/kotlin/com/apollographql/apollo3/network/websocket/WebSocketNetworkTransport.kt
Outdated
Show resolved
Hide resolved
...cubating/src/jsMain/kotlin/com/apollographql/apollo3/network/websocket/WebSocketEngine.js.kt
Show resolved
Hide resolved
...g/src/commonMain/kotlin/com/apollographql/apollo3/network/websocket/SubscribableWebSocket.kt
Outdated
Show resolved
Hide resolved
|
Obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new
NetworkTransportfor WebSockets that rewrites most of the internal machinery:This fixes a couple of issues:
And should make debugging easier for other ones like:
The new
NetworkTransportis namedWebSocketNetworkTransport, just like the current one. The only thing that changes is the package name, fromcom.apollographql.apollo3.network.wstocom.apollographql.apollo3.network.websocket. The current plan is to:apollo-websocket-network-transport-incubating).WsProtocolAPI that is wildly changed. Anyone using a customWsProtocolwill need to rewrite some code but I think this is for the greater good.Opening as draft the time to re-read everything and add KDoc
Relates to #5648