Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[apollo-mockserver] cosmetics and add listener #5360

Merged
merged 2 commits into from
Nov 8, 2023
Merged

[apollo-mockserver] cosmetics and add listener #5360

merged 2 commits into from
Nov 8, 2023

Conversation

martinbonnin
Copy link
Contributor

A few small tweaks to [MockServer]:

  • improve KDoc
  • add a listener for logging purposes
  • rename BinaryMessage to DataMessage so that it's the same length as TextMessage

@martinbonnin martinbonnin requested a review from BoD as a code owner November 8, 2023 10:14
@netlify Netlify
Copy link

netlify bot commented Nov 8, 2023 •
edited
Loading

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 3d3019e
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/654b9080a473150008135a9f

BoD
BoD approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin merged commit 5100819 into main Nov 8, 2023
7 checks passed
@martinbonnin martinbonnin deleted the mockserver-listener branch November 8, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinbonnin @BoD