Add ApolloWebSocketHandler #5291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbonnin
added a commit
that referenced
this pull request
Oct 12, 2023
* add apollo-execution and apollo-ksp * Allo to disable publication of modules (#5282) * move build logic to plain APIS * disable publishing * remove unused function * enable publishing of apollo-normalized-cache-*-incubating * add comment * remove unused source/target compatibility. They are overriden by --release * Use apollo-execution in our integration tests (#5288) * use apollo-execution for integration tests * unhide a bunch of internals * more comments * hide some of the websocket implementation (#5291) * Make CodegenLayout internal again, use CodegenMetadata.resolveSchemaType instead (#5292) * make CodegenLayout internal again, use CodegenMetadata.resolveSchemaType instead * Update libraries/apollo-ksp/src/main/kotlin/com/apollographql/apollo3/ksp/ksp-validation.kt Co-authored-by: Benoit Lubek <[email protected]> --------- Co-authored-by: Benoit Lubek <[email protected]> --------- Co-authored-by: Benoit Lubek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ApolloWebSocketHandler is higher level and allows to hide the implementation details of the WebSocket messages.
Also part of this PR is wrapping
dataOrThrow()exceptions inNoDataExceptionfor better stacktraces