minor fixes and additions #905
Conversation
|
Hello @Slaw6820 thank you for the contribution, could you split the one commit into the separate changes? |
|
Sure. Does it mean that all proposed fixes are accepted? |
LTGM, but I'm not an biggest authority here :) just commits within this MR :) |
There was a problem hiding this comment.
Sorry for the silence -- I was on vacation last week.
Thanks for the changes. Comments inline.
Otherwise looks good. I agree it would be good to break the changes according to main modules (wrappers, retrace, etc. The main reason is that one can git bisect and revert chunks
| api < other.api || | ||
| core < other.core || | ||
| forwardCompatible < other.forwardCompatible; | ||
| return (major < other.major) || |
There was a problem hiding this comment.
Good catch.
There's a more compact way to achieve the same:
if (major != other.major) {
return major < other.major;
}
if (minor != other.minor) {
return minor < other.minor;
}
...| @@ -221,7 +221,16 @@ OpenGLImpl::skipDeleteObj(const trace::Call& call) | |||
| map = &m_textures; | |||
|
|
|||
| if (!strcmp(call.name(), "glDeleteFramebuffers")) | |||
| map = &m_current_context->m_fbo; | |||
| { | |||
There was a problem hiding this comment.
Code formatting should be
if (condition) {
....
}| #endif | ||
|
|
||
|
|
||
| #define assert(expression) \ |
During my work with apitrace I have encountered a small number of issues that were addressed with the following changes to the source code.
Please review.