Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glMultiDrawArraysIndirect not capturing client buffer #678

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sturmlilie
Copy link

I'm not entirely sure why using Blob instead of OpaqueArray makes this work, but it does.
In case stride is zero, it means "the array is tightly packed" [1].

[1] https://www.khronos.org/registry/OpenGL/extensions/ARB/ARB_multi_draw_indirect.txt

@Sturmlilie
Copy link
Author

I just realized that the command allows (and is primarily geared towards) usage with a buffer object bound, in which case this patch will likely copy from an invalid memory address. Will investigate how to differentiate between the two cases.

@jrfonseca
Copy link
Member

It's not easy to do this sort of stuff (polymorphism) just from the spec, but it can be done.

See

def GLindexBuffer(countExpr, typeExpr):
for example, on how the index buffers are handled. They too can either be a memory pointer, or a buffer offset, depending on whether an index buffer is bound.

@jrfonseca jrfonseca added Further Work Needed For PRs which need more work. Tracing labels Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Further Work Needed For PRs which need more work. Tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants