Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update eslint to v9, use new shared config #568

Merged
merged 9 commits into from
Jan 15, 2025
Merged

chore: update eslint to v9, use new shared config #568

merged 9 commits into from
Jan 15, 2025

Conversation

jirimoravcik
Copy link
Member

This PR updates eslint to v9 along with the new flat config. We also use the new shared Apify config.

@jirimoravcik jirimoravcik requested a review from Copilot January 15, 2025 13:50
Copilot
Copilot AI reviewed Jan 15, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
@github-actions github-actions bot added this to the 107th sprint - Platform team milestone Jan 15, 2025
@github-actions github-actions bot added the t-platform Issues with this label are in the ownership of the platform team. label Jan 15, 2025
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Jan 15, 2025
@jirimoravcik
Copy link
Member Author

I had to:

  • Pin ubuntu in CI to 22, because with latest I was getting nasty kernel errors when launching puppeteer
  • Use Node 18 instead of 16 in lint CI because of structuredClone, which was added in Node 17

tobice
tobice approved these changes Jan 15, 2025
View reviewed changes
Copy link

@tobice tobice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look safe 👍

Just two suggestions how to possibly approach certain parts better.

src/utils/normalize_url_port.ts Outdated Show resolved Hide resolved
test/tcp_tunnel.js Show resolved Hide resolved
@jirimoravcik jirimoravcik merged commit 4c1fee5 into master Jan 15, 2025
5 checks passed
@jirimoravcik jirimoravcik deleted the chore/update-eslint-config branch January 15, 2025 16:38
@jirimoravcik jirimoravcik mentioned this pull request Jan 15, 2025
Closed
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@tobice tobice tobice approved these changes

@fnesveda fnesveda fnesveda approved these changes

Assignees

@jirimoravcik jirimoravcik

Labels
t-platform Issues with this label are in the ownership of the platform team. tested Temporary label used only programatically for some analytics. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Milestone
107th sprint - Platform team
Development

Successfully merging this pull request may close these issues.
3 participants
@jirimoravcik @fnesveda @tobice