Add proxy headers, add support for the https proxy

[theArina]

Sorry for the mess though.
#121, #47 related.

[mnmkng]

Could you clean this up a bit please? There are a lot of unrelated changes in this PR caused by old commits. I have no idea what this PR would do when it has 900 changed lines in the diff.

[theArina]

@mnmkng, sure.

[theArina]

@mnmkng, hey, should I've even made a PR into this branch ? I now realise that it was updated long ago. And I was pulling changes from master.

[mnmkng]

Yeah, you're right. I missed it. Please make the PR against master, not develop. Thanks.

[theArina]

@mnmkng, here you go!

[jancurn]

@theArina thanks for your PR and the cleanup. However, there are still zero comments explaining what your changes do and what they are good for, and zero new unit tests for those changes. Also, I don't think it makes sense to add one more dependency "rimraf" just to enable "npm clean" command, that's just too wasteful.

[B4nan]

Also, I don't think it makes sense to add one more dependency "rimraf" just to enable "npm clean" command, that's just too wasteful.

It depends - if we want to make this repository windows friendly, we can't use just rm (that's the point of rimraf, being platform independent). But it should be a dev dependency.

Granted, this is not related to the PR itself and would be better done separately.

[theArina]

I'll see what I can do with the comments and stuff.
It's just at first we made changes for the personal usage, but I thought someone else might also need this stuff.

[jancurn]

@theArina I totally understand and are grateful for your help, we just require a certain standard for this library, as it's used quite a bit, including our own production systems.

[szmarczak]

Using the CONNECT protocol is unnecessary. This is just a regular web proxy.

proxy-chain/src/handler_forward.js

Line 114 in 0043ac9

this.trgRequest = http.request(reqOpts);

const fn = reqOpts.protocol === 'https:' ? https.request : http.request;
this.trgRequest = fn(reqOpts); 

and it should work.

[szmarczak]

HTTPS proxy support should be now possible via replacing

proxy-chain/src/server.ts

Line 407 in f1bbe42

if (handlerOpts.upstreamProxyUrlParsed.protocol !== 'http:') {

with

const { protocol } = handlerOpts.upstreamProxyUrlParsed;
if (protocol !== 'http:' && protocol !== 'https:') {