Skip to content

Commit

Permalink
chore: Do not install poetry in install-dev make target (#500)
Browse files Browse the repository at this point in the history
  • Loading branch information
janbuchar authored Sep 5, 2024
1 parent 6a3e0e7 commit 0e3f595
Show file tree
Hide file tree
Showing 8 changed files with 25 additions and 10 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/_check_changelog_entry.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ jobs:
python-version: "3.9"

- name: Install dependencies
run: make install-dev
run: |
pipx install poetry
make install-dev
- name: Check changelog entry
run: make check-changelog-entry
7 changes: 5 additions & 2 deletions .github/workflows/_check_docs_build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,11 @@ jobs:
with:
python-version: 3.12

- name: Install Python dependencies
run: make install-dev
- name: Install dependencies
run: |
pipx install poetry
make install-dev
- name: Build generated API reference
run: make build-api-reference
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/_linting.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Install dependencies
run: make install-dev
run: |
pipx install poetry
make install-dev
- name: Run linting
run: make lint
4 changes: 3 additions & 1 deletion .github/workflows/_publish_to_pypi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ jobs:
run: pipx install poetry

- name: Install dependencies
run: make install-dev
run: |
pipx install poetry
make install-dev
# Updates the version number in the project's configuration.
- name: Set version in pyproject.toml
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/_type_checking.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Install dependencies
run: make install-dev
run: |
pipx install poetry
make install-dev
- name: Run type checking
run: make type-check
4 changes: 3 additions & 1 deletion .github/workflows/_unit_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Install dependencies
run: make install-dev
run: |
pipx install poetry
make install-dev
- name: Run unit tests
run: make unit-tests
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/docs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,10 @@ jobs:
with:
python-version: 3.12

- name: Install Python dependencies
run: make install-dev
- name: Install dependencies
run: |
pipx install poetry
make install-dev
- name: Build generated API reference
run: make build-api-reference
Expand Down
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ clean:
rm -rf .mypy_cache .pytest_cache .ruff_cache build dist htmlcov .coverage

install-dev:
python3 -m pip install --upgrade pip poetry
poetry install --all-extras
poetry run pre-commit install
poetry run playwright install
Expand Down

0 comments on commit 0e3f595

Please sign in to comment.