Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Flake8 & Autopep8 to Ruff #14

Merged
merged 7 commits into from
Nov 16, 2023
Merged

Migrate from Flake8 & Autopep8 to Ruff #14

merged 7 commits into from
Nov 16, 2023

Conversation

vdusek
Copy link
Contributor

@vdusek vdusek commented Nov 11, 2023

Description

  • Ruff presents an extensive set of rules. I decided to adopt a strategy of enabling all rules by default and selectively disabling specific rules or entire rule groups as needed (either for the whole project/directory/specific file).
  • The code was automatically formatted using ruff format and ruff check --fix, some easy fixes were performed manually, and some rule violations were turned off for the particular line of code.
    • Including the usage of from __future__ import annotations which will be discussed separately.
  • Also Makefile, CONTRIBUTING.md, .gitignore, and a few other files were slightly updated.

Issue

@github-actions github-actions bot added this to the 76th sprint - Tooling team milestone Nov 11, 2023
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Nov 11, 2023
@vdusek vdusek changed the title Migrate from Flake8 and Autopep8 to Ruff Migrate from Flake8 & Autopep8 to Ruff Nov 13, 2023
@vdusek vdusek marked this pull request as ready for review November 14, 2023 08:35
@vdusek vdusek requested a review from jirimoravcik November 14, 2023 08:35
Copy link
Member

@jirimoravcik jirimoravcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, had some comments

Makefile Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
src/apify_shared/models.py Show resolved Hide resolved
tests/unit/test_utils.py Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@vdusek vdusek merged commit 0b3c734 into master Nov 16, 2023
16 of 17 checks passed
@vdusek vdusek deleted the migrate-to-ruff branch November 16, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Ruff (linter & formatter)
2 participants