Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Set up an automated release process #691

Merged
merged 5 commits into from
Nov 7, 2024
Merged

Conversation

janbuchar
Copy link
Contributor

@janbuchar janbuchar added the t-tooling Issues with this label are in the ownership of the tooling team. label Nov 4, 2024
@janbuchar janbuchar requested review from vladfrangu and B4nan November 4, 2024 17:05
@github-actions github-actions bot added this to the 102nd sprint - Tooling team milestone Nov 4, 2024
.github/workflows/pre_release.yaml Show resolved Hide resolved
Comment on lines 133 to 135
env:
NODE_AUTH_TOKEN: ${{ secrets.APIFY_SERVICE_ACCOUNT_NPM_TOKEN }}
NPM_TOKEN: ${{ secrets.APIFY_SERVICE_ACCOUNT_NPM_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nest this into the publish to npm step
also i doubt we need it twice

.github/workflows/pre_release.yaml Show resolved Hide resolved
.github/workflows/release.yaml Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
@janbuchar janbuchar force-pushed the automated-release-process branch from ff049fa to 3363c48 Compare November 5, 2024 10:34
@janbuchar janbuchar requested a review from vladfrangu November 5, 2024 10:43
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/pre_release.yaml Outdated Show resolved Hide resolved
@janbuchar janbuchar merged commit e9b35f5 into master Nov 7, 2024
17 checks passed
@janbuchar janbuchar deleted the automated-release-process branch November 7, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New release process
3 participants