Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bootstrap new command namespaces #632

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

vladfrangu
Copy link
Member

Prepares the following namespaces for commands:

  • actors
  • runs
  • key-value-stores
  • datasets
  • request-queues

@github-actions github-actions bot added this to the 97th sprint - Tooling team milestone Sep 4, 2024
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Sep 4, 2024
@vladfrangu vladfrangu requested a review from B4nan September 4, 2024 15:13
@vladfrangu vladfrangu added the adhoc Ad-hoc unplanned task added during the sprint. label Sep 4, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@vladfrangu
Copy link
Member Author

Bleh, labelling as adhoc because idk if I can link up 3 issues (and it solves only like 1% of each)

Copy link
Contributor

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

import { ApifyCommand } from '../../lib/apify_command.js';

export class ActorIndexCommand extends ApifyCommand<typeof ActorIndexCommand> {
static override description = 'Commands are designed to be used with Actors.';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an override, I guess it'll get glued to something else before printing to the console? On its own, the wording would be kinda weird.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, its printed when you run apify actors alone

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what's the exact thing that gets printed in that case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code - 2024-09-06 at 13 45 59@2x

When you have commands those get listed too

Code - 2024-09-06 at 13 46 29@2x

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, thanks. Then I'd probably reword those descriptions along the lines of "Commands for working with Actors" or "for management of Actors"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats more of a @netmilk task, I just did what we did for other namespaces. Agreed it could use better copies but I wouldn't wanna block feature implementation just bc of that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get it, but if we don't do it now, there will always be something more pressing than changing wording.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but that can hopefully be done in parallel by Adam 👀. This also ties into @barjin's comments on #620 about wording tbh, we definitely need a pass on all wording and improve it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made #637 to track this

@vladfrangu vladfrangu changed the title feat: new command namespaces feat: bootstrap new command namespaces Sep 9, 2024
@vladfrangu vladfrangu merged commit 0d58e70 into master Sep 9, 2024
21 checks passed
@vladfrangu vladfrangu deleted the feat/bootstrap-namespaces branch September 9, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants