chore: support new crawlee purge logic #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been a pain and a half to work in, especially because no TS 😢 but that'll change soon 😏
vladfrangu
force-pushed
the
chore/no-purge
branch
from
726f4a2 to
c759f52
Compare
github-actions
bot
added
the
t-tooling
janbuchar
approved these changes
Feb 6, 2024
B4nan
approved these changes
Feb 6, 2024
| return false; | ||
| } | ||
|
|
||
| // We cannot infer |
There was a problem hiding this comment.
this basically means "use latest version", so use crawlee v3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been a pain and a half to work in, especially because no TS 😢 but that'll change soon 😏
Also adds in proper migration support to custom folders instead of a hardcoded folder for storages, full redirect of storages based on ENV variables, and a base for detecting old apify-based actors (who knows, maybe it'll be useful in the future)
Closes #373