Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump ts-playwright-test-runner Playwright and Node version #307

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

barjin
Copy link
Contributor

@barjin barjin commented Dec 18, 2024

Bumps the Playwright and Node versions in the template to latests. Fixes the hanging browserContext.newPage() call by passing the --disable-gpu launch option to the browser.

More context at https://apify.slack.com/archives/CGZSN9DQC/p1733928283797729

@barjin barjin requested a review from B4nan December 18, 2024 12:07
@github-actions github-actions bot added this to the 105th sprint - Tooling team milestone Dec 18, 2024
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Dec 18, 2024
@barjin
Copy link
Contributor Author

barjin commented Dec 18, 2024

I see that other templates using Playwright (e.g. ts-playwright-chrome or js-playwright-chrome) use the unpinned base Docker image (apify/actor-node-playwright-chrome:20, without the playwright version tag).

What's the consensus on this? I remember that there were some nasty bugs caused by the installed browser / npm-installed Playwright version mismatch, right?

Should we unpin Playwright here too? Or should we rather pin the Playwright version in the other templates?

@barjin barjin added the adhoc Ad-hoc unplanned task added during the sprint. label Dec 18, 2024
@barjin
Copy link
Contributor Author

barjin commented Dec 18, 2024

And, on related note, shouldn't we pass the --disable-gpu flag to the other templates as well? Since those are "Apify templates", I'd assume they work perfectly on Apify, no user tweaks ever needed.

@B4nan
Copy link
Member

B4nan commented Dec 18, 2024

What's the consensus on this? I remember that there were some nasty bugs caused by the installed browser / npm-installed Playwright version mismatch, right?

My point of view is that we should pin it, but we are missing some automation to keep the templates up to date, I am not sure if renovate can pick this up properly. And the docs of course, I am not sure if we have some suggestions on the "old way" (don't commit lockfile, use * in deps and don't pin in docker tag).

And, on related note, shouldn't we pass the --disable-gpu flag to the other templates as well? Since those are "Apify templates", I'd assume they work perfectly on Apify, no user tweaks ever needed.

Makes sense to me.

@barjin barjin force-pushed the chore/bump-playwright-test-version branch from 15bc339 to 56719db Compare December 18, 2024 12:38
@barjin barjin merged commit d7579f0 into master Dec 18, 2024
16 checks passed
@barjin barjin deleted the chore/bump-playwright-test-version branch December 18, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants