-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump ts-playwright-test-runner
Playwright and Node version
#307
Conversation
I see that other templates using Playwright (e.g. ts-playwright-chrome or js-playwright-chrome) use the unpinned base Docker image ( What's the consensus on this? I remember that there were some nasty bugs caused by the installed browser / npm-installed Playwright version mismatch, right? Should we unpin Playwright here too? Or should we rather pin the Playwright version in the other templates? |
And, on related note, shouldn't we pass the |
My point of view is that we should pin it, but we are missing some automation to keep the templates up to date, I am not sure if renovate can pick this up properly. And the docs of course, I am not sure if we have some suggestions on the "old way" (don't commit lockfile, use
Makes sense to me. |
15bc339
to
56719db
Compare
Bumps the Playwright and Node versions in the template to
latest
s. Fixes the hangingbrowserContext.newPage()
call by passing the--disable-gpu
launch option to the browser.More context at https://apify.slack.com/archives/CGZSN9DQC/p1733928283797729