fix: Specify the same Chrome and Chromedriver version in tests #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnesveda
added
bug
|
Damn, this doesn't work, now I know why I had to specify the version there in the first place 😄 |
fnesveda
changed the title
B4nan
approved these changes
Jul 26, 2023
fnesveda
added
the
validated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, if you pass
chromedriver-versiontosetup-chromedriver, it will install the given Chromedriver version, but it will also install latest Chrome which might not be compatible to the given Chromedriver version.There is now a better way to install the same Chrome and Chromedriver, using Chrome for Testing and
npx @puppeteer/browsers install ....