Skip to content

Commit

Permalink
fix: Add 60 minutes timeout to template tests (#292)
Browse files Browse the repository at this point in the history
The broken template tests cost us $500 in the last month, because the
tests were running for 6 hours before they timed out. This adds a 1-hour
time limit to them, so that next time they time out earlier and it's not
so costly.

I checked and the tests typically run for 30 minutes, so 1 hour timeout
should be enough.
  • Loading branch information
fnesveda authored Sep 6, 2024
1 parent 2439e96 commit 731ab98
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/lint_and_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ jobs:
node-version: [ 18, 20, 22 ]
fail-fast: false
runs-on: ${{ matrix.os }}
timeout-minutes: 60

steps:
- name: Checkout repo
Expand Down Expand Up @@ -92,6 +93,7 @@ jobs:
os: [ubuntu-latest, windows-latest]
python-version: [ '3.9', '3.10', '3.11', '3.12' ]
runs-on: ${{ matrix.os }}
timeout-minutes: 60

steps:
- name: Checkout repo
Expand Down

0 comments on commit 731ab98

Please sign in to comment.