Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to use crawlee #23

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Refactor to use crawlee #23

merged 3 commits into from
Nov 12, 2024

Conversation

Pijukatel
Copy link
Contributor

No description provided.

@Pijukatel
Use crawlee
3c102a5 
Remove custom functions and use generic functions from Crawlee instead.
Use pydantic for Actor input data.
@Pijukatel
Update documentation.
7c42a03
@Pijukatel Pijukatel added t-tooling Issues with this label are in the ownership of the tooling team. debt Code quality improvement or decrease of technical debt. labels Nov 12, 2024
@github-actions github-actions bot added this to the 102nd sprint - Tooling team milestone Nov 12, 2024
@Pijukatel Pijukatel requested a review from vdusek November 12, 2024 08:20
@Pijukatel
Copy link
Contributor Author

I tested actor here: https://console.apify.com/actors/hRZbnFhePGa88AhMQ/source

vdusek
vdusek reviewed Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few details, otherwise it's great 🙂

CHANGELOG.md Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
src/input_handling.py Show resolved Hide resolved
@Pijukatel @vdusek
Update CHANGELOG.md
13a43fd 
Co-authored-by: Vlada Dusek <[email protected]>
vdusek
vdusek approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pijukatel Pijukatel merged commit 2fc779e into master Nov 12, 2024
2 checks passed
@Pijukatel Pijukatel deleted the refactor_to_use_crawlee branch November 12, 2024 10:44
This was referenced Nov 12, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdusek vdusek vdusek approved these changes

Assignees

@Pijukatel Pijukatel

Labels
debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
102nd sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
2 participants
@Pijukatel @vdusek