Skip to content

Commit

Permalink
Merge 3.4 (#6507)
Browse files Browse the repository at this point in the history
* tests: remove output suffix after reverting

* cs: remove unnecessary comments (#6408)

* fix(elasticsearch): change normalize return type to compatible with other normalizers (#6493)

* style: various cs fixes (#6504)

* cs: fixes

* chore: phpstan fixes

* style: cs fixes

---------

Co-authored-by: Takashi Kanemoto <[email protected]>
Co-authored-by: Koen Pasman <[email protected]>
  • Loading branch information
3 people authored Aug 9, 2024
1 parent c05a526 commit 2939cc3
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions Tests/JsonSchema/SchemaFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,7 @@ public function testHasRootDefinitionKeyBuildSchema(): void
$definitions = $resultSchema->getDefinitions();
$rootDefinitionKey = $resultSchema->getRootDefinitionKey();

// @noRector
$this->assertTrue(isset($definitions[$rootDefinitionKey]));
// @noRector
$this->assertTrue(isset($definitions[$rootDefinitionKey]['properties']));
$properties = $resultSchema['definitions'][$rootDefinitionKey]['properties'];
$this->assertArrayHasKey('data', $properties);
Expand Down Expand Up @@ -132,7 +130,6 @@ public function testSchemaTypeBuildSchema(): void
$definitionName = 'Dummy.jsonapi';

$this->assertNull($resultSchema->getRootDefinitionKey());
// @noRector
$this->assertTrue(isset($resultSchema['properties']));
$this->assertArrayHasKey('links', $resultSchema['properties']);
$this->assertArrayHasKey('self', $resultSchema['properties']['links']['properties']);
Expand Down Expand Up @@ -160,7 +157,6 @@ public function testSchemaTypeBuildSchema(): void
$resultSchema = $this->schemaFactory->buildSchema(Dummy::class, 'jsonapi', Schema::TYPE_OUTPUT, forceCollection: true);

$this->assertNull($resultSchema->getRootDefinitionKey());
// @noRector
$this->assertTrue(isset($resultSchema['properties']));
$this->assertArrayHasKey('links', $resultSchema['properties']);
$this->assertArrayHasKey('self', $resultSchema['properties']['links']['properties']);
Expand Down

0 comments on commit 2939cc3

Please sign in to comment.