Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update next generator #369

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

malikalahfaoui
Copy link
Contributor

Q A
Branch? main for features / current stable version branch for bug fixes
Tickets Closes #..., closes #...
License MIT
Doc PR api-platform/docs#...

@malikalahfaoui
Copy link
Contributor Author

Done:

Migrated Pages router to App router
Migrated Formik to React Hook Form
To do:
Remaining tasks / bugs to fix:

Issue with page titles
React query hydration
Validation with React Hook Form

@malikalahfaoui malikalahfaoui marked this pull request as draft August 22, 2023 15:38
@malikalahfaoui malikalahfaoui marked this pull request as ready for review September 18, 2023 13:19
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not necessary.

status.isValid ? "text-cyan-700 border-cyan-500 bg-cyan-200/50" : "text-red-700 border-red-400 bg-red-100"
}`}
className={`border px-4 py-3 my-4 rounded ${
isValid Object.keys(errors).length === 0 ? "text-cyan-700 border-cyan-500 bg-cyan-200/50" : "text-red-700 border-red-400 bg-red-100"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think isValid is wrong here

@@ -1,10 +1,11 @@
import { FunctionComponent, useState } from "react";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"use client"; is missing

@@ -25,12 +25,12 @@ export default class NextGenerator extends BaseGenerator {
"types/item.ts",

// pages

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can change this to app

@@ -92,11 +95,11 @@ export default class NextGenerator extends BaseGenerator {
"components/%s/Form.tsx",

// pages

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can change this to app

@@ -116,7 +119,7 @@ export default class NextGenerator extends BaseGenerator {
"types/item.ts",

// pages

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can change this to app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants