-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update next generator #369
base: main
Are you sure you want to change the base?
Conversation
malikalahfaoui
commented
Aug 22, 2023
Q | A |
---|---|
Branch? | main for features / current stable version branch for bug fixes |
Tickets | Closes #..., closes #... |
License | MIT |
Doc PR | api-platform/docs#... |
Done: Migrated Pages router to App router Issue with page titles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not necessary.
status.isValid ? "text-cyan-700 border-cyan-500 bg-cyan-200/50" : "text-red-700 border-red-400 bg-red-100" | ||
}`} | ||
className={`border px-4 py-3 my-4 rounded ${ | ||
isValid Object.keys(errors).length === 0 ? "text-cyan-700 border-cyan-500 bg-cyan-200/50" : "text-red-700 border-red-400 bg-red-100" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think isValid
is wrong here
@@ -1,10 +1,11 @@ | |||
import { FunctionComponent, useState } from "react"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"use client";
is missing
@@ -25,12 +25,12 @@ export default class NextGenerator extends BaseGenerator { | |||
"types/item.ts", | |||
|
|||
// pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can change this to app
@@ -92,11 +95,11 @@ export default class NextGenerator extends BaseGenerator { | |||
"components/%s/Form.tsx", | |||
|
|||
// pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can change this to app
@@ -116,7 +119,7 @@ export default class NextGenerator extends BaseGenerator { | |||
"types/item.ts", | |||
|
|||
// pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can change this to app