Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "commonmark/markdown" style links #67

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rpavlik
Copy link
Contributor

@rpavlik rpavlik commented Aug 31, 2022

That is, like this: [link text](url). Useful for readability, especially when generating nullboard boards from things like gitlab issues/merge requests.

I think the better solution is probably to combine both http link processing regexes into one, instead of negative lookbehind/lookahead, but this was my first attempt. If I get a chance to do better I'll update this or submit a new PR.

I did put a second commit to underline those links, since unlike a string starting with https, it's not clear that these links, once processed, are actually links in the absence of link-like formatting.

@rpavlik rpavlik mentioned this pull request Sep 7, 2022
@apankrat
Copy link
Owner

I'd rather hide this behavior behind a config option and have it switched off by default. The reason being is that, currently, clicking on a text does not cause any visual changes, just makes it editable. This patch alters this behavior by making static and editable texts different. Yes, it's doable, there's some utility to it and it's not a big change, but small doable things pave the road to you know where.

@rpavlik
Copy link
Contributor Author

rpavlik commented Nov 14, 2022

Sure, that makes sense. It's pretty important for my use case (compensating for cruddy project management abilities in gitlab) but I can see how it's not important to probably many others. I'm fine carrying this in my own fork if you prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants