Support Java 16 records in property lookup #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java 16 records (JEP 395) are a perfect fit for Velocity variables: they are lightweight and desgined to contain immutable data. However, records don’t follow the JavaBean convention: the getter of the field `foo` is `foo()`, not `getFoo()`. Add support for this naming convention. While this naming convention is mostly useful in projects using Java 16 records, the patch itself doesn’t rely on records, so it doesn’t break Java 1.8 compatibility.
|
Stupid question: is this limited to records only or will it work with any method without get prefix? |
|
Actually, I could only test it with regular classes because of the project’s Java 1.8 support. So other methods work definitely, records work hopefully. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java 16 records (JEP 395) are a perfect fit for Velocity variables: they are lightweight and desgined to contain immutable data. However, records don’t follow the JavaBean convention: the getter of the field
fooisfoo(), notgetFoo(). Add support for this naming convention.While this naming convention is mostly useful in projects using Java 16 records, the patch itself doesn’t rely on records, so it doesn’t break Java 1.8 compatibility.