[SPARK-50601][SQL] Support withColumns / withColumnsRenamed in subqueries #49386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan too |
zhengruifeng
approved these changes
Jan 7, 2025
cloud-fan
reviewed
Jan 7, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Jan 10, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Jan 10, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Jan 10, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
Show resolved
Hide resolved
cloud-fan
reviewed
Jan 10, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Jan 10, 2025
| @@ -1275,29 +1275,15 @@ class Dataset[T] private[sql]( | |||
| require(colNames.size == cols.size, | |||
There was a problem hiding this comment.
Is this check still needed?
There was a problem hiding this comment.
I think it's still good to have to be fail-fast, especially for connect?
cloud-fan
reviewed
Jan 10, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
Show resolved
Hide resolved
…ysis/unresolved.scala Co-authored-by: Wenchen Fan <[email protected]>
ueshin
changed the title
|
|
cloud-fan
approved these changes
Jan 13, 2025
|
The remaining test failures are not related to this PR. |
|
Thanks! merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Supports
withColumns/withColumnsRenamedin subqueries.Why are the changes needed?
When the query is used as a subquery by adding
col.outer(),withColumnsorwithColumnsRenameddoesn't work because they need analyzed plans.Does this PR introduce any user-facing change?
Yes, those APIs are available in subqueries.
How was this patch tested?
Added the related tests.
Was this patch authored or co-authored using generative AI tooling?
No.