[SPARK-50735][CONNECT] Failure in ExecuteResponseObserver results in infinite reattaching requests #49370
+79
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changgyoopark-db
force-pushed
the
SPARK-50735
branch
4 times, most recently
from
e495228 to
d3391c7
Compare
|
Hey, @juliuszsompolski , I hope you are doing well. Can you please review this change? |
changgyoopark-db
force-pushed
the
SPARK-50735
branch
from
039cb9d to
8e8773c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ExecuteGrpcResponseSender checks whether the associated ExecuteThreadRunner is completed to return an error if the ExecuteThreadRunner has failed to record the outcome.
Why are the changes needed?
ExecuteResponseObserver.{onError, onComplete} are fallible while they are not retried; this leads to a situation where the ExecuteThreadRunner is completed without succeeding in responding to the client, and thus the client keeps retrying by reattaching the execution.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
testOnly org.apache.spark.sql.connect.service.SparkConnectServiceE2ESuite
Was this patch authored or co-authored using generative AI tooling?
No.