Addresses comments from #623 in ActiveRolesProvider #708
+18
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collado-mike
requested review from
adutra,
ashvina,
dimas-b,
eric-maynard,
jackye1995,
jbonofre,
vvcephei,
snazy,
RussellSpitzer,
takidau,
flyrain and
ebyhr
as code owners
adutra
reviewed
Jan 12, 2025
| @@ -53,6 +54,10 @@ public void filter(ContainerRequestContext requestContext) throws IOException { | |||
| public SecurityContext createSecurityContext( | |||
| SecurityContext ctx, AuthenticatedPolarisPrincipal principal) { | |||
| Set<String> validRoleNames = activeRolesProvider.getActiveRoles(principal); | |||
| if (validRoleNames.isEmpty()) { | |||
There was a problem hiding this comment.
This is making the tests fail, and I think we do have a problem. DefaultActiveRolesProvider expects the principal to have the role PRINCIPAL_ROLE_ALL when all roles are activated:
boolean allRoles = tokenRoles.contains(BasePolarisAuthenticator.PRINCIPAL_ROLE_ALL);But BasePolarisAuhtenticator creates a principal with an empty roles set in that case. You need to change BasePolarisAuthenticator.getPrincipal():
if (tokenInfo.getScope() != null) {
if (tokenInfo.getScope().equals(PRINCIPAL_ROLE_ALL)) {
activatedPrincipalRoles.add(PRINCIPAL_ROLE_ALL); // this is missing
} else {
activatedPrincipalRoles.addAll(...);
}
}
|
@collado-mike if you want to rebase this PR, the two filters were moved/renamed to:
Both are in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses comments from #623