Fix Azure path comparison when filePath is root ("/") #385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
AzureLocation.isChildOf
method is currently broken if the parent path points to the root of the container (e.g.abfss://[email protected]
orabfss://[email protected]/
). ThefilePath
of the path in this case would be parsed as/
since we always add a "trailing slash". Now if the comparing child path looks something likeabfss://[email protected]/some/file/path/metadata
, thefilePath
would be parsed assome/file/path/metadata/
after applying the trailing slash, leading to the failure of thechildFilePath.startsWith(parentFilePath)
check since the childFilePath doesn't start with a slash.Fix is to always ensure a leading slash on top of ensuring a trailing slash.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist:
Please delete options that are not relevant.