Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Cleanup with build warnings. #362

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Code Cleanup with build warnings. #362

merged 4 commits into from
Oct 16, 2024

Conversation

nk1506
Copy link
Contributor

@nk1506 nk1506 commented Oct 9, 2024

As part of this cleanup replaced hardcoded response status code with enum.

@ebyhr
Copy link
Contributor

ebyhr commented Oct 9, 2024

@nk1506 Could you rebase on main to resolve conflicts?

snazy
snazy approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snazy snazy enabled auto-merge (squash) October 15, 2024 13:08
@snazy snazy mentioned this pull request Oct 15, 2024
Merged
@snazy snazy merged commit 9dfab70 into apache:main Oct 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snazy snazy snazy approved these changes

@jbonofre jbonofre Awaiting requested review from jbonofre jbonofre is a code owner

@ashvina ashvina Awaiting requested review from ashvina ashvina is a code owner

@RussellSpitzer RussellSpitzer Awaiting requested review from RussellSpitzer RussellSpitzer is a code owner

@vvcephei vvcephei Awaiting requested review from vvcephei vvcephei is a code owner

@takidau takidau Awaiting requested review from takidau takidau is a code owner

@jackye1995 jackye1995 Awaiting requested review from jackye1995 jackye1995 is a code owner

@flyrain flyrain Awaiting requested review from flyrain flyrain is a code owner

@eric-maynard eric-maynard Awaiting requested review from eric-maynard eric-maynard is a code owner

@collado-mike collado-mike Awaiting requested review from collado-mike collado-mike is a code owner

@ebyhr ebyhr Awaiting requested review from ebyhr ebyhr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nk1506 @ebyhr @snazy