Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure when mounting local volume during quick start guide execution #356

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

MonkeyCanCode
Copy link
Contributor

@MonkeyCanCode MonkeyCanCode commented Oct 8, 2024

Description

Fix issue reported in 349 by change volume mount to FS mount.

Fixes #349

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Test for docker-compose.yml:

➜  polaris git:(349) ✗ docker compose -f docker-compose.yml up --build
...
[+] Building 173.5s (37/37) 
...
FINISHED                                                                                                                 
[+] Running 2/2
 ✔ Container polaris-polaris-1  Recreated                                                                                                                            0.1s
 ✔ Container polaris-regtest-1  Recreated                                                                                                                            0.1s
Attaching to polaris-1, regtest-1
...
polaris-1  |
polaris-1  |
polaris-1  |
polaris-1  |                                       /////\
polaris-1  |                                    //\\///T\\\
polaris-1  |                                 ///\\\////\\\\\\
polaris-1  |                                //\\\\T////\\\\\\\\\
polaris-1  |                           /T\ //\\\\\T///T\\//T\\\\\\
polaris-1  |                         //\\\/////T\\////\\/////\\\\\\\  //\\
polaris-1  |                      //\\\\\\T///////////////////T\\\\\\\T\\\\\
polaris-1  |                   //\\\\/////T\//////////\///////T\\\\\T\\\\\\\\
polaris-1  |                  //\\\\\/////\\\T////////////////\\\\\\/\\\\\\\\\
polaris-1  | ,,..,,,..,,,..,//\\\\////////\\\\\\\\\\/////////\\\\\///\\\\\\\\\\,,,..,,..,,,..,,,.
polaris-1  | ,,..,,,..,,,..,,,..,,,..,,,..,,,..,,,..,,,..,,,..,,,..,,,..,,,..,,,..,,,.,,,..,,,..,
polaris-1  |

Test for docker-compose-jupyter.yml:

➜  polaris git:(349) ✗ docker compose -f docker-compose-jupyter.yml up --build
...
[+] Building 288.7s (29/29) FINISHED                                                                                                                 
...
Attaching to jupyter-1, polaris-1
...
polaris-1  |
polaris-1  |  @@@@   @@@  @       @    @@@@   @  @@@@    @@@@    @  @@@@@  @    @     @@@   @@@@
polaris-1  |  @   @ @   @ @      @ @   @   @  @  @@     @       @ @   @   @ @   @    @   @ @
polaris-1  |  @@@@  @   @ @     @@@@@  @@@@   @    @@   @      @@@@@  @  @@@@@  @    @   @ @  @@@
polaris-1  |  @      @@@  @@@@ @     @ @  @@  @  @@@@    @@@@ @     @ @ @@   @@ @@@@  @@@   @@@@
polaris-1  |
polaris-1  |
polaris-1  |
polaris-1  |
polaris-1  |                                       /////\
polaris-1  |                                    //\\///T\\\
polaris-1  |                                 ///\\\////\\\\\\
polaris-1  |                                //\\\\T////\\\\\\\\\
polaris-1  |                           /T\ //\\\\\T///T\\//T\\\\\\
polaris-1  |                         //\\\/////T\\////\\/////\\\\\\\  //\\
polaris-1  |                      //\\\\\\T///////////////////T\\\\\\\T\\\\\
polaris-1  |                   //\\\\/////T\//////////\///////T\\\\\T\\\\\\\\
polaris-1  |                  //\\\\\/////\\\T////////////////\\\\\\/\\\\\\\\\
polaris-1  | ,,..,,,..,,,..,//\\\\////////\\\\\\\\\\/////////\\\\\///\\\\\\\\\\,,,..,,..,,,..,,,.
polaris-1  | ,,..,,,..,,,..,,,..,,,..,,,..,,,..,,,..,,,..,,,..,,,..,,,..,,,..,,,..,,,.,,,..,,,..,
polaris-1  |

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • If adding new functionality, I have discussed my implementation with the community using the linked GitHub issue

Copy link
Contributor

@adutra adutra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm this works with Docker Desktop 4.34.2 on macOS.

@ebyhr ebyhr changed the title Fix 349 Fix failure when mounting local volume during quick start guide execution Oct 9, 2024
@eric-maynard
Copy link
Contributor

Hey @MonkeyCanCode , can you take a look at the merge conflict? Then we should merge. Thanks!

@MonkeyCanCode
Copy link
Contributor Author

Hey @MonkeyCanCode , can you take a look at the merge conflict? Then we should merge. Thanks!

Fixed.

@eric-maynard eric-maynard enabled auto-merge (squash) October 17, 2024 21:51
@eric-maynard eric-maynard merged commit b33d84a into apache:main Oct 18, 2024
5 checks passed
@MonkeyCanCode MonkeyCanCode deleted the 349 branch December 12, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Failed to Mount Local Volume During Quick Start Guide Execution
3 participants