Fix minor issues like possible NPE, unused local variable, typo. #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nk1506
requested review from
jbonofre,
ashvina,
RussellSpitzer,
snazy,
vvcephei,
takidau and
jackye1995
as code owners
nk1506
force-pushed
the
m_fix
branch
2 times, most recently
from
7e9af2b to
115a736
Compare
|
@nk1506 Sorry about this but can you rebase? Looks like we are out of sync |
aihuaxu
reviewed
Sep 24, 2024
polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java
Outdated
Show resolved
Hide resolved
| ioImplClassName, | ||
| storageConfigurationInfo); | ||
| } else { | ||
| throw new ValidationException( |
There was a problem hiding this comment.
Should we just log a warning here since storageConfiguration could be null?
There was a problem hiding this comment.
@aihuaxu Are you requesting that no exception get thrown here?
There was a problem hiding this comment.
Yeah. What I meant is not to throw exception but just log a warning since storageConfiguration could be null.
nk1506
requested review from
eric-maynard,
collado-mike and
ebyhr
as code owners
eric-maynard
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix minor issues as NPE, unused varibale, typo.