Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OFBIZ-12989 #745

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

OFBIZ-12989 #745

wants to merge 1 commit into from

Conversation

gtchaboussie
Copy link

Improved:
Implemented:
Documented:
Completed:
Reverted:
Fixed:
(OFBIZ-)

Explanation

Thanks:

Copy link

sonarcloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mbrohl
Copy link
Contributor

mbrohl commented Apr 4, 2024

Hi @gtchaboussie ,

some hints: please stick to our commit message template for proper commit messages.
Also, please create a PR with the OFBiz Jira issue numer in the title (OFBIZ-XXXXX). This will allow Jira to automatically link the PR to the Jira issue.

Thanks!

@gtchaboussie
Copy link
Author

Hi @mbrohl thanks for the advices. I thought i'd squash the commits and edit the commit message at that time, is that ok ?
I'll edit the PR name right away.

@gtchaboussie gtchaboussie changed the title WIP tomcat 10 migration OFBIZ-12989 Apr 5, 2024
@JacquesLeRoux
Copy link
Contributor

Hi @gtchaboussie ,

Yes that works too

@JacquesLeRoux
Copy link
Contributor

Hi @gtchaboussie,

I'm working on https://issues.apache.org/jira/browse/OFBIZ-12985, for now https://issues.apache.org/jira/browse/OFBIZ-12995 as a 1st step, so there are few conflicts in accoutning and there will be more in all applications. I suggest that you wait or often update your branch because these fixes have priority. We can't get ahead (freezing a 24.xx branch notably) w/o the integration tests all working. TIA

@gtchaboussie
Copy link
Author

thanks for the heads up. I'll focus on https://issues.apache.org/jira/browse/OFBIZ-12991 for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants