[cgroups2] Introduces the MemoryControllerProcess. #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevinLeamy
force-pushed
the
mem-controller
branch
from
8dc4672
to
7021d84
Compare
DevinLeamy
force-pushed
the
mem-controller
branch
3 times, most recently
from
ef27991
to
4573f73
Compare
Introduces the `MemoryControllerProcess`, the cgroups v2 memory isolator, which will be used by the `Cgroups2IsolatorProcess`. Unlike the `MemorySubsystemProcess`, the cgroups v1 memory isolator, we: - Don't allow limits on swap memory to be set. - Don't report memory pressure levels (this facility is no longer part of the cgroups memory controller's API) Future work may include: - Adding support for swap memory, and - Reporting the (now available) memory pressure stall information
DevinLeamy
force-pushed
the
mem-controller
branch
from
4573f73
to
08be78a
Compare
ZhouJas
reviewed
May 8, 2024
| Bytes softLimit = std::max(memory, MIN_MEMORY); | ||
|
|
||
| // Set the soft memory limit. | ||
| Try<Nothing> high = cgroups2::memory::set_high(cgroup, softLimit); |
There was a problem hiding this comment.
This should be set_low instead for the same behavior as soft limit in v1
|
Going to land this via #581 instead since it needed a minor fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the
MemoryControllerProcess, the cgroups v2 memoryisolator, which will be used by the
Cgroups2IsolatorProcess.Unlike the
MemorySubsystemProcess, the cgroups v1 memory isolator, we:of the cgroups memory controller's API)
Future work may include:
This patch updates the
ROOT_MemUsageso it passes on a cgroups v2 machine using the newMemoryControllerProcess.