Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-8419][MNG-8424] Too aggressive warning for pre-Maven4 passwords #1970

Merged
merged 8 commits into from
Dec 12, 2024

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Dec 12, 2024

Toned down the Maven4 sec dispatcher messages. Also, IF maven3 passwords detected AND there was .mvn/extensions.xml the warnings were doubled.

Examples:

Failure to start Maven (due non-decryptable passwords):

$ mvn clean
[ERROR] Error executing Maven.
[ERROR] Error building settings
 * FATAL: Could not decrypt password (fix the corrupted password or remove it, if unused) {xL6L/HbmrY++sNkphnq3fguYepTpM04WlIXb8nB1pk=}
 * WARNING: Detected 2 pre-Maven 4 legacy encrypted password(s) - configure password encryption with the help of mvnenc for increased security.
$

Warning at start (due Maven3 passwords):

$ mvn clean
[INFO]
[INFO] Some problems were encountered while building the effective settings (use -X to see details)
[INFO]
[INFO] Scanning for projects...
[INFO] --------------------------------------------------------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] Apache Maven
...

https://issues.apache.org/jira/browse/MNG-8424
https://issues.apache.org/jira/browse/MNG-8419

Toned down the Maven4 sec dispatcher messages.

Examples:

Failure to start Maven (due non-decryptable passwords):
```
$ mvn clean
[ERROR] Error executing Maven.
[ERROR] Error building settings
 * FATAL Could not decrypt password (fix the corrupted password or remove it, if unused) {xL6L/HbmrY++sNkphnq3fguYepTpM04WlIXb8nB1pk=}
 * WARNING Detected 2 pre-Maven 4 legacy encrypted password(s) - configure password encryption with the help of mvnenc for increased security.
$
```

Warning at start (due Maven3 passwords):
```
$ mvn clean
[INFO]
[INFO] Some problems were encountered while building the effective settings (use -X to see details)
[INFO]
[INFO] Scanning for projects...
[INFO] --------------------------------------------------------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] Apache Maven
...
```

---

https://issues.apache.org/jira/browse/MNG-8424
https://issues.apache.org/jira/browse/MNG-8419
@cstamas cstamas added this to the 4.0.0-rc-2 milestone Dec 12, 2024
@cstamas cstamas requested a review from gnodet December 12, 2024 13:53
@cstamas cstamas self-assigned this Dec 12, 2024
@cstamas cstamas marked this pull request as ready for review December 12, 2024 14:08
@cstamas cstamas changed the title [MNG-8424] Too aggressive warning for pre-Maven4 passwords [MNG-8419][MNG-8424] Too aggressive warning for pre-Maven4 passwords Dec 12, 2024
@cstamas cstamas merged commit 50aecc7 into apache:master Dec 12, 2024
13 checks passed
@cstamas cstamas deleted the MNG-8424 branch December 12, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants