Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore fsync behavior in FSDirectory via P/Invoke, #933 #938

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Restore fsync behavior in FSDirectory via P/Invoke, #933 #938

wants to merge 15 commits into from

Commits on May 11, 2024

  1. Restore fsync behavior in FSDirectory via P/Invoke 

    This restores the commented-out fsync behavior in FSDirectory to help
mitigate a performance regression in .NET 8.
    @paulirwin
    paulirwin committed May 11, 2024
    Configuration menu
    Copy the full SHA
    b2b8cdc View commit details
    Browse the repository at this point in the history

  2. Use System.IO.Directory.Exists to avoid caching exists status

    @paulirwin
    paulirwin committed May 11, 2024
    Configuration menu
    Copy the full SHA
    9740c22 View commit details
    Browse the repository at this point in the history

  3. Add unit test for ConcurrentHashSet.ExceptWith

    @paulirwin
    paulirwin committed May 11, 2024
    Configuration menu
    Copy the full SHA
    4c489e2 View commit details
    Browse the repository at this point in the history

  4. Improve errors thrown by CreateFileW

    @paulirwin
    paulirwin committed May 11, 2024
    Configuration menu
    Copy the full SHA
    c57f6b3 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Change FileSystemInfo use to string in IOUtils.Fsync

    @paulirwin
    paulirwin committed May 15, 2024
    Configuration menu
    Copy the full SHA
    50f7b06 View commit details
    Browse the repository at this point in the history

  2. Change Debug.Assert to Debugging use

    @paulirwin
    paulirwin committed May 15, 2024
    Configuration menu
    Copy the full SHA
    5f59ce1 View commit details
    Browse the repository at this point in the history

  3. Lucene.Net.Index.TestIndexWriterOnJRECrash::TestNRTThreads_Mem(): Rem… 

    …oved AwaitsFix attribute. The FSync implementation should fix this test.
    @NightOwl888
    NightOwl888 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    3635caa View commit details
    Browse the repository at this point in the history

  4. Make ExceptWith atomic

    @paulirwin
    paulirwin committed May 15, 2024
    Configuration menu
    Copy the full SHA
    2682952 View commit details
    Browse the repository at this point in the history

  5. Improve error handling if directory not found on Linux/macOS

    @paulirwin
    paulirwin committed May 15, 2024
    Configuration menu
    Copy the full SHA
    21c7196 View commit details
    Browse the repository at this point in the history

  6. Refactor interop methods into separate partial class files

    @paulirwin
    paulirwin committed May 15, 2024
    Configuration menu
    Copy the full SHA
    2623a01 View commit details
    Browse the repository at this point in the history

  7. Lucene.Net.Index.TestIndexWriterOnJRECrash::TestNRTThreads_Mem(): Add… 

    …ed [Repeat(25)] attribute.
    @NightOwl888
    NightOwl888 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    f3f3459 View commit details
    Browse the repository at this point in the history

  8. Lucene.Net.Index.TestIndexWriterOnJRECrash: Instead of using a temp f… 

    …ile to pass the process ID to kill back to the original test process, open a socket and listen for the process ID to be written.
    @NightOwl888
    NightOwl888 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    72649b2 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Synchronize access to stale files collection 

    This is necessary to prevent race conditions, even though this code is
not in the upstream Java code. A thread could try to add an item to the
collection after it has been synced in `Sync` but before it is removed
from the collection, then the file is removed from the collection,
resulting in a missed sync.
    @paulirwin
    paulirwin committed May 16, 2024
    Configuration menu
    Copy the full SHA
    8d97713 View commit details
    Browse the repository at this point in the history

  2. Rename syncLock to m_syncLock

    @paulirwin
    paulirwin committed May 16, 2024
    Configuration menu
    Copy the full SHA
    2af651b View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Lucene.Net.Index.TestIndexWriterOnJRECrash: Added try/finally block a… 

    …nd refactored to ensure the TcpListener and Process are cleaned up at the end of each test iteration. This makes it run ~20% faster.
    @NightOwl888
    NightOwl888 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    b3a425f View commit details
    Browse the repository at this point in the history