Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-10241][Sort] TLog format requires the ability to parse and determine if the first segment is present #10243

Merged
merged 3 commits into from
May 23, 2024
Merged

[INLONG-10241][Sort] TLog format requires the ability to parse and determine if the first segment is present #10243

merged 3 commits into from
May 23, 2024

Conversation

baomingyu
Copy link
Contributor

Fixes #10241

Motivation

Modifications

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@baomingyu baomingyu self-assigned this May 20, 2024
vernedeng
vernedeng approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@vernedeng vernedeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dockerzhang dockerzhang merged commit d18232b into apache:master May 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dockerzhang dockerzhang dockerzhang approved these changes

@vernedeng vernedeng vernedeng approved these changes

@aloyszhang aloyszhang aloyszhang approved these changes

@luchunliang luchunliang Awaiting requested review from luchunliang

@gosonzhang gosonzhang Awaiting requested review from gosonzhang

Assignees

@baomingyu baomingyu

Labels
component/sort
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][Sort] TLog format requires the ability to parse and determine if the first segment is present.
4 participants
@baomingyu @dockerzhang @vernedeng @aloyszhang