Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEODE-10237: Remove no-ack from testThinClientTransactionsWithSticky #959

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

GEODE-10237: Remove no-ack from testThinClientTransactionsWithSticky #959

wants to merge 2 commits into from

Conversation

mmartell
Copy link
Contributor

This removes the no-ack functionality from this test, which fails regularly in the CI.

@mmartell mmartell force-pushed the GEODE-10237-fix-transactions-test branch from ba07d13 to fa70213 Compare April 17, 2022 15:31
pdxcodemonkey
pdxcodemonkey requested changes May 2, 2022
View reviewed changes
Copy link
Contributor

@pdxcodemonkey pdxcodemonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is, IMO, too much code to duplicate, and adding the new file rather than editing the existing one really obscures the nature of this change. Please try just editing ThinClientTrasactions.hpp and resubmit.

@mmartell
Cleanup per review:
e74a925 
- no need for an additional header file
- just refactor the original include file
@mmartell
Copy link
Contributor Author

mmartell commented May 2, 2022

This is, IMO, too much code to duplicate, and adding the new file rather than editing the existing one really obscures the nature of this change. Please try just editing ThinClientTrasactions.hpp and resubmit.

Good catch Blake! Not sure why I thought I needed to use a new header file. As you point out, just needed to refactor the original header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echobravopapa echobravopapa Awaiting requested review from echobravopapa

@pdxcodemonkey pdxcodemonkey Awaiting requested review from pdxcodemonkey

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmartell @pdxcodemonkey