[FLINK-35400][checkpoint] Release FileMergingSnapshotManager if all tasks finished #24817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ask attempts finished
jectpro7
approved these changes
May 22, 2024
fredia
reviewed
May 23, 2024
| @@ -74,8 +79,9 @@ public TaskExecutorFileMergingManager() { | |||
| * Initialize file merging snapshot manager for each job according configurations when {@link | |||
| * org.apache.flink.runtime.taskexecutor.TaskExecutor#submitTask}. | |||
| */ | |||
| public @Nullable FileMergingSnapshotManager fileMergingSnapshotManagerForJob( | |||
| public @Nullable FileMergingSnapshotManager fileMergingSnapshotManagerForTask( | |||
There was a problem hiding this comment.
How about renaming it to fileMergingSnapshotManagerForAttempt?
There was a problem hiding this comment.
I'd prefer the Task, since this manager will be used to create a TaskStateManager which will be given to a Task. The Task is more in line with the caller’s cognition.
| @@ -53,7 +57,8 @@ public class TaskExecutorFileMergingManager { | |||
| * manager(executor). | |||
| */ | |||
| @GuardedBy("lock") | |||
| private final Map<JobID, FileMergingSnapshotManager> fileMergingSnapshotManagerByJobId; | |||
There was a problem hiding this comment.
I'm not sure if using <JobID, ExecutionAttemptID> directly as the key is enough? to avoid nesting.
There was a problem hiding this comment.
Well I suggest no. We still need to call releaseMergingSnapshotManagerForJob in releaseJobResources as a safety guard, where we use the job id to retrieve a manager.
fredia
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Currently, the
FileMergingSnapshotManageris created for each job, only when the corresponding job released, the manager is released and disposed. For failover scenario, the tasks quit but job is still there, leading a reuse ofFileMergingSnapshotManager, which violates the design ofFileMergingSnapshotManager.Brief change log
TaskExecutorFileMergingManagerrecord reference fromExecutionAttemptIDtoFileMergingSnapshotManager, and release the reference when task resources release.Verifying this change
This change is already covered by modified existing tests, such as
TaskExecutorFileMergingManagerTest.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation