Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-35382][test] Disable snapshot-file-merging in ChangelogCompabilityITCase #24813

Merged
merged 1 commit into from
May 21, 2024

Conversation

ljz2051
Copy link
Contributor

@ljz2051 ljz2051 commented May 20, 2024

What is the purpose of the change

This pull request disable snapshot-file-merging config in ChangelogCompabilityITCase.

Brief change log

  • Disable the FILE_MERGING_ENABLED config in ChangelogCompabilityITCase

Verifying this change

This change is already covered by existing tests (ChangelogCompabilityITCase).

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@ljz2051
Copy link
Contributor Author

ljz2051 commented May 20, 2024

This pr is to resolve the unstable case (ChangelogCompatibilityITCase#testRestore).
@fredia Could you please help to review this fix?

@flinkbot
Copy link
Collaborator

flinkbot commented May 20, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@fredia fredia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ljz2051 Thanks for the fix, LGTM

@fredia fredia merged commit 26b149a into apache:master May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants