Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spring related transitive dependencies from dubbo-all #14137

Open
wants to merge 2 commits into
base: 3.3
Choose a base branch
from

Conversation

chickenlj
Copy link
Contributor

  1. spring xml related samples need to be adjusted to meet this change
  2. documentation needs to be updated for non spring-boot users
  3. spring-boot users would not be affected, but with dependency conflict chances reduced

@AlbumenJ
Copy link
Member

AlbumenJ commented May 8, 2024

  1. Test cases should be fixed first
  2. Why add protobuf dependencies?

@chickenlj
Copy link
Contributor Author

  1. Test cases should be fixed first

I am now working on it.

  1. Why add protobuf dependencies?

As triple going to become the major protocol of Dubbo framework in the next release, I think we should have it by default, just like what we do with hessian2 before.

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to remove spring dependencies from dubbo-all.
Dubbo is used in three ways:

  1. dubbo API (without spring)
  2. dubbo + dubbo-config-spring (without SpringBoot)
  3. dubbo + SpringBoot (dubbo-spring-boot-starter)

Copy link

sonarcloud bot commented May 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants