-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a readme for clickbench intro #3186
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3186 +/- ##
==========================================
+ Coverage 85.86% 85.87% +0.01%
==========================================
Files 291 291
Lines 52793 52827 +34
==========================================
+ Hits 45329 45366 +37
+ Misses 7464 7461 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @waitingkuo -- rather than add something to the root directory, what would you think about putting this data into https://github.com/apache/arrow-datafusion/tree/master/benchmarks ?
I think it is similar in spirit to https://github.com/apache/arrow-datafusion/tree/master/benchmarks/db-benchmark
@alamb sure i can do it. let me spend sometime checking how db-benchmark works. should i move |
@waitingkuo moving conbench would be great |
|
||
## To generate human readable results | ||
|
||
your can do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your can do | |
you can do |
bash run2.sh | ||
``` | ||
|
||
Each query will be only exeute only once, for each query it'll print the SQL expression first then output the result. (Note that this index begins with 1, the ClickBench begins with 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each query will be only exeute only once, for each query it'll print the SQL expression first then output the result. (Note that this index begins with 1, the ClickBench begins with 0) | |
Each query will be executed only once, for each query it'll print the SQL expression first then output the result. (Note that this index begins with 1, the ClickBench begins with 0) |
@@ -0,0 +1,52 @@ | |||
<!--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should move this file to benchmarks/clickbench/README.md
so that all the benchmarks are in one place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all of the work on this @waitingkuo. It is great to see results published.
FYI here is another approach to running clickbench in the datafusion repo: #7060 |
Closing as this PR is over a year old. Please feel free to reopen it / rebase it if you plan to keep working on it |
Which issue does this PR close?
Closes #2902
Rationale for this change
initial work to add datafusion into https://benchmark.clickhouse.com/
What changes are included in this PR?
Are there any user-facing changes?