Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a readme for clickbench intro #3186

Closed
wants to merge 3 commits into from

Conversation

waitingkuo
Copy link
Contributor

Which issue does this PR close?

Closes #2902

Rationale for this change

initial work to add datafusion into https://benchmark.clickhouse.com/

What changes are included in this PR?

Are there any user-facing changes?

@codecov-commenter
Copy link

Codecov Report

Merging #3186 (6289054) into master (85f7fc9) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 6289054 differs from pull request most recent head 7dae4c6. Consider uploading reports for the commit 7dae4c6 to get more accurate results

@@            Coverage Diff             @@
##           master    #3186      +/-   ##
==========================================
+ Coverage   85.86%   85.87%   +0.01%     
==========================================
  Files         291      291              
  Lines       52793    52827      +34     
==========================================
+ Hits        45329    45366      +37     
+ Misses       7464     7461       -3     
Impacted Files Coverage Δ
datafusion/optimizer/src/eliminate_filter.rs 100.00% <0.00%> (ø)
datafusion/core/src/physical_plan/hash_utils.rs 40.05% <0.00%> (ø)
datafusion/core/tests/sql/aggregates.rs 99.36% <0.00%> (+<0.01%) ⬆️
datafusion/expr/src/aggregate_function.rs 92.33% <0.00%> (+0.02%) ⬆️
datafusion/common/src/scalar.rs 84.74% <0.00%> (+0.13%) ⬆️
datafusion/physical-expr/src/aggregate/min_max.rs 95.91% <0.00%> (+0.16%) ⬆️
datafusion/expr/src/logical_plan/plan.rs 77.95% <0.00%> (+0.17%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @waitingkuo -- rather than add something to the root directory, what would you think about putting this data into https://github.com/apache/arrow-datafusion/tree/master/benchmarks ?

I think it is similar in spirit to https://github.com/apache/arrow-datafusion/tree/master/benchmarks/db-benchmark

@waitingkuo
Copy link
Contributor Author

@alamb sure i can do it. let me spend sometime checking how db-benchmark works. should i move conbench as well?

@alamb
Copy link
Contributor

alamb commented Aug 17, 2022

@waitingkuo moving conbench would be great

@waitingkuo waitingkuo marked this pull request as draft August 17, 2022 09:51

## To generate human readable results

your can do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
your can do
you can do

bash run2.sh
```

Each query will be only exeute only once, for each query it'll print the SQL expression first then output the result. (Note that this index begins with 1, the ClickBench begins with 0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Each query will be only exeute only once, for each query it'll print the SQL expression first then output the result. (Note that this index begins with 1, the ClickBench begins with 0)
Each query will be executed only once, for each query it'll print the SQL expression first then output the result. (Note that this index begins with 1, the ClickBench begins with 0)

@@ -0,0 +1,52 @@
<!---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should move this file to benchmarks/clickbench/README.md so that all the benchmarks are in one place.

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all of the work on this @waitingkuo. It is great to see results published.

@alamb
Copy link
Contributor

alamb commented Jul 24, 2023

FYI here is another approach to running clickbench in the datafusion repo: #7060

@alamb
Copy link
Contributor

alamb commented Nov 28, 2023

Closing as this PR is over a year old. Please feel free to reopen it / rebase it if you plan to keep working on it

@alamb alamb closed this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding DataFusion to ClickBench benchmarks
4 participants