Update to apache-avro 0.17, fix compatibility changes schema handling #13727
+128
−137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- updated-dependencies: - dependency-name: apache-avro dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
mdroogh
force-pushed
the
dependabot/cargo/main/apache-avro-0.17
branch
2 times, most recently
from
a78e358 to
55ca31b
Compare
- Handle ArraySchema struct - Handle MapSchema struct - Map BigDecimal => LargeBinary - Map TimestampNanos => Timestamp(TimeUnit::Nanosecond, None) - Map LocalTimestampNanos => todo!() - Add Default to FixedSchema test
mdroogh
force-pushed
the
dependabot/cargo/main/apache-avro-0.17
branch
from
55ca31b to
9174983
Compare
alamb
changed the title
…/apache-avro-0.17
alamb
changed the base branch from
dependabot/cargo/main/apache-avro-0.17
to
main
alamb
approved these changes
Dec 11, 2024
| @@ -144,14 +148,17 @@ fn schema_to_field_with_props( | |||
| AvroSchema::Decimal(DecimalSchema { | |||
| precision, scale, .. | |||
| }) => DataType::Decimal128(*precision as u8, *scale as i8), | |||
| AvroSchema::BigDecimal => DataType::LargeBinary, | |||
There was a problem hiding this comment.
I wondered if there would be a more useful mapping for BigDecimal, but it seems like binary is good for now:
https://docs.rs/apache-avro/latest/apache_avro/schema/enum.Schema.html#variant.BigDecimal
There was a problem hiding this comment.
I tend to agree, it's not very clear what would be the best mapping.
If it has the preference, we can also set it to "todo!()" that was done for some other types.
alamb
changed the title
|
Thanks! @alamb For next time, should I just point the MR to |
Yes, please! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13588.
Rationale for this change
Making sure apache-avro can be bumped to version 0.17.
What changes are included in this PR?
Are these changes tested?
Not really, making the code compile.
Are there any user-facing changes?
Not really.