Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Minor code improvements suggested by newer clippy #13666

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

findepi
Copy link
Member

@findepi findepi commented Dec 5, 2024

Minor code improvements. These gonna be suggested edits in future Rust version.

relates to #13631

This will become a clippy warning in the future.
The `len()` returns length in bytes, so doing `as_bytes().len()` is
redundant. This will become a clippy warning in the future.
@findepi findepi requested a review from crepererum December 5, 2024 15:34
@github-actions github-actions bot added physical-expr Physical Expressions core Core DataFusion crate functions labels Dec 5, 2024
Copy link
Contributor

@crepererum crepererum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@comphead comphead merged commit b30edc8 into apache:main Dec 5, 2024
25 checks passed
@findepi findepi deleted the findepi/return-from-the-future branch December 5, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate functions physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants