Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CI build failed on main #13640

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix: CI build failed on main #13640

merged 2 commits into from
Dec 4, 2024

Conversation

jonahgao
Copy link
Member

@jonahgao jonahgao commented Dec 4, 2024

Which issue does this PR close?

Closes #13639.

Rationale for this change

There is a logical conflict between #13611 and main.
indexmap::IndexSet was replaced to common::IndexSet in #13611, but there's still code using it on the main.

What changes are included in this PR?

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added the physical-expr Physical Expressions label Dec 4, 2024
Copy link
Member

@Weijun-H Weijun-H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick fix @jonahgao 👍

@Weijun-H Weijun-H merged commit acc9f41 into apache:main Dec 4, 2024
26 checks passed
@jonahgao
Copy link
Member Author

jonahgao commented Dec 4, 2024

Thanks @Weijun-H for the review.

@jonahgao jonahgao deleted the fix_ci branch December 4, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI build failed on main
2 participants