Report current operation when coercion fails #13628
Open
+43
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/errctx
branch
from
e20ee07
to
def1c98
Compare
Weijun-H
reviewed
Dec 3, 2024
| @@ -218,7 +240,8 @@ fn try_coerce_types( | |||
|
|
|||
| // none possible -> Error | |||
| plan_err!( | |||
| "Coercion from {:?} to the signature {:?} failed.", | |||
| "{}: coercion from {:?} to the signature {:?} failed.", | |||
There was a problem hiding this comment.
How about this?
Suggested change
| "{}: coercion from {:?} to the signature {:?} failed.", | |
| "Function {} failed to coerce from {:?} to the signature {:?}.", |
This makes for a more actionable error message.
findepi
force-pushed
the
findepi/errctx
branch
from
def1c98
to
766c348
Compare
alamb
approved these changes
Dec 3, 2024
| @@ -1357,7 +1357,7 @@ mod test { | |||
|
|
|||
| let err = Projection::try_new(vec![udaf], empty).err().unwrap(); | |||
| assert!( | |||
| err.strip_backtrace().starts_with("Error during planning: Error during planning: Coercion from [Utf8] to the signature Uniform(1, [Float64]) failed") | |||
| err.strip_backtrace().starts_with("Error during planning: Error during planning: MY_AVG: coercion from [Utf8] to the signature Uniform(1, [Float64]) failed") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes for a more actionable error message.