Create ArrayScalarBuilder for creating single element List arrays
#13623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/single_row_array
branch
from
be70e93 to
26f2492
Compare
alamb
commented
Dec 2, 2024
| @@ -321,89 +321,180 @@ pub fn longest_consecutive_prefix<T: Borrow<usize>>( | |||
| count | |||
| } | |||
|
|
|||
| /// Creates single element [`ListArray`], [`LargeListArray`] and | |||
There was a problem hiding this comment.
The idea is to pull the wrapping code into this structure so it remains consistent across list types
jayzhan211
reviewed
Dec 3, 2024
datafusion/common/src/utils/mod.rs
Outdated
| /// assert_eq!(list_arr.len(), 1); | ||
| /// ``` | ||
| #[derive(Debug, Clone)] | ||
| pub struct SingleRowArrayBuilder { |
There was a problem hiding this comment.
It seems this builder is for List, maybe name with SingleRowListArrayBuilder is more concise?
jayzhan211
approved these changes
Dec 3, 2024
|
Thanks @alamb |
|
Thank you @jayzhan211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
There are a bewildering number of small free functions for performing the same basic thing: converting an array into a single row list array / scalar
This has also lead to subtle bugs such as #13481
Let's encapsulate that operation into a well documented structure
What changes are included in this PR?
ArrayScalarBuilderAre these changes tested?
Are there any user-facing changes?