Implement RightSemi join for SortMergeJoin #13584
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
athultr1997
force-pushed
the
athultr/right_semi_join
branch
3 times, most recently
from
8d8c5ca
to
6976ce4
Compare
athultr1997
force-pushed
the
athultr/right_semi_join
branch
from
6976ce4
to
319b87c
Compare
comphead
reviewed
Nov 28, 2024
There was a problem hiding this comment.
Thanks @athultr1997
I'll check the tests later this week.
Unfortunately we cannot call RIGHT SEMI/ RIGHT ANTI directly from SQL, it can be chosen by the optimizer so I'm feeling we need to focus more on unit tests
| JoinType::RightSemi, | ||
| None, | ||
| ) | ||
| .run_test(&[HjSmj, NljHj], true) |
There was a problem hiding this comment.
Suggested change
| .run_test(&[HjSmj, NljHj], true) | |
| .run_test(&[HjSmj, NljHj], false) |
| JoinType::RightSemi, | ||
| Some(Box::new(col_lt_col_filter)), | ||
| ) | ||
| .run_test(&[HjSmj, NljHj], true) |
There was a problem hiding this comment.
Suggested change
| .run_test(&[HjSmj, NljHj], true) | |
| .run_test(&[HjSmj, NljHj], false) |
| @@ -508,6 +508,124 @@ select t1.* from t1 where not exists (select 1 from t2 where t2.a = t1.a and t1. | |||
| ---- | |||
|
|
|||
|
|
|||
| # RIGHTSEMI join tests | |||
There was a problem hiding this comment.
Im not sure these tests makes a difference as RIGHT SEMI are not supported by SQL this type of join can be called by optimizer on physical executiion
| @@ -732,7 +727,7 @@ struct JoinedRecordBatches { | |||
| pub batches: Vec<RecordBatch>, | |||
| /// Filter match mask for each row(matched/non-matched) | |||
| pub filter_mask: BooleanBuilder, | |||
| /// Row indices to glue together rows in `batches` and `filter_mask` | |||
| /// Streamed row indices to glue together rows in `batches` and `filter_mask` | |||
There was a problem hiding this comment.
Suggested change
| /// Streamed row indices to glue together rows in `batches` and `filter_mask` | |
| /// Left row indices to glue together rows in `batches` and `filter_mask` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13471
Rationale for this change
Adds support for RightSemi join in SortMergeJoin
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?