Skip to content

Commit

Permalink
feat(substrait): remove dependency on datafusion default features (#1…
Browse files Browse the repository at this point in the history
…3594)

* feat(substrait): remove dependency on datafusion default features

* ci(substrait): check without default features
  • Loading branch information
notfilippo authored Dec 4, 2024
1 parent 049ca15 commit 11d49b4
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 3 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,12 @@ jobs:
- name: Check datafusion-common without default features
run: cargo check --all-targets --no-default-features -p datafusion-common

- name: Check datafusion-functions
- name: Check datafusion-functions without default features
run: cargo check --all-targets --no-default-features -p datafusion-functions

- name: Check datafusion-substrait without default features
run: cargo check --all-targets --no-default-features -p datafusion-substrait

- name: Check workspace in debug mode
run: cargo check --all-targets --workspace

Expand Down Expand Up @@ -603,4 +606,4 @@ jobs:
run: cargo msrv --output-format json --log-target stdout verify
- name: Check datafusion-cli
working-directory: datafusion-cli
run: cargo msrv --output-format json --log-target stdout verify
run: cargo msrv --output-format json --log-target stdout verify
4 changes: 3 additions & 1 deletion datafusion/substrait/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ arrow-buffer = { workspace = true }
async-recursion = "1.0"
async-trait = { workspace = true }
chrono = { workspace = true }
datafusion = { workspace = true, default-features = true }
datafusion = { workspace = true }
itertools = { workspace = true }
object_store = { workspace = true }
pbjson-types = "0.7"
Expand All @@ -51,4 +51,6 @@ serde_json = "1.0"
tokio = { workspace = true }

[features]
default = ["physical"]
physical = ["datafusion/parquet"]
protoc = ["substrait/protoc"]
1 change: 1 addition & 0 deletions datafusion/substrait/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
//! ```
pub mod extensions;
pub mod logical_plan;
#[cfg(feature = "physical")]
pub mod physical_plan;
pub mod serializer;
pub mod variation_const;
Expand Down
1 change: 1 addition & 0 deletions datafusion/substrait/tests/cases/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ mod emit_kind_tests;
mod function_test;
mod logical_plans;
mod roundtrip_logical_plan;
#[cfg(feature = "physical")]
mod roundtrip_physical_plan;
mod serialize;
mod substrait_validations;

0 comments on commit 11d49b4

Please sign in to comment.