Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify SpiderMonkey couchjs sources #5321

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

big-r81
Copy link
Contributor

@big-r81 big-r81 commented Oct 23, 2024

Hi,

I tried to combine and merge the different SpiderMonkey source files together.

During compiling with SM v128 I got the following error message:

[1] Compiling /Users/big-r/Documents/Developer/CouchDB/couchdb/src/couch/priv/couch_js/102/util.cpp
/Users/big-r/Documents/Developer/CouchDB/couchdb/src/couch/priv/couch_js/102/util.cpp:327:17: error: invalid operands to binary expression ('std::ostringstream' (aka 'basic_ostringstream<char>') and 'JS::ConstUTF8CharsZ')
            msg << report->filename;
            ~~~ ^  ~~~~~~~~~~~~~~~~

[2] /Users/big-r/Documents/Developer/CouchDB/couchdb/src/couch/priv/couch_js/102/util.cpp:333:49: error: invalid operands to binary expression ('basic_ostream<char, char_traits<char>>' and 'JS::ColumnNumberOneOrigin')
            msg << ':' << report->lineno << ':' << report->column;
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~

I fixed these both errors with the following statements:

[1] msg << report->filename.c_str();

[2] msg << ':' << report->lineno << ':' << report->column.oneOriginValue();

After that change, I successful compiled against v91, v115 and v128 und run the Fauxton checks!
It seems, that the missing part in all version was the deepFreeze function...

Here is the full log: error.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants