INSTALL.Unix: update libmozjs install tips #5107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older versions of libmozjs-dev may not be available to install from package repos, and newer versions may work fine.
|
@alxndrsn Thanks for the update. The latest supported version of Spidermonkey is v91. |
Would a better change therefore be: ? |
nickva
reviewed
Jul 6, 2024
| @@ -66,7 +66,7 @@ You can install the dependencies by running: | |||
| build-essential pkg-config erlang erlang-reltool \ | |||
| libicu-dev libmozjs-60-dev python3 | |||
|
|
|||
| Your distribution may have `libmozjs-68-dev` instead of 60. Both are supported. | |||
| Your distribution may have `libmozjs-68-dev` instead of 60. Both are supported. Newer versions of `libmozjs-...-dev` may also work; you can find which are available using `apt-cache search libmozjs`. | |||
There was a problem hiding this comment.
I suggest mention Newer versions less or equal to 91 of libmozjs... just to be a bit more explicit.
itszeeshan
suggested changes
Sep 2, 2024
| @@ -66,7 +66,7 @@ You can install the dependencies by running: | |||
| build-essential pkg-config erlang erlang-reltool \ | |||
| libicu-dev libmozjs-60-dev python3 | |||
|
|
|||
| Your distribution may have `libmozjs-68-dev` instead of 60. Both are supported. | |||
| Your distribution may have `libmozjs-68-dev` instead of 60. Both are supported. Newer versions of `libmozjs-...-dev` may also work; you can find which are available using `apt-cache search libmozjs`. | |||
There was a problem hiding this comment.
I would suggest this, which is i think a bit more comprehensive approach.
Your distribution might provide libmozjs-68-dev instead of libmozjs-60-dev, and both are supported. Additionally, newer versions of libmozjs-...-dev may also be compatible. To see which versions are available, use the command "apt-cache search libmozjs"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of libmozjs-dev may not be available to install from package repos, and newer versions may work fine.