[CALCITE-5737] Support jdk21 and jdk22 #3793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snuyanzin
commented
May 19, 2024
| @@ -792,6 +808,9 @@ allprojects { | |||
| inputs.property("java.vm.version", System.getProperty("java.vm.version")) | |||
| options.encoding = "UTF-8" | |||
| options.compilerArgs.add("-Xlint:deprecation") | |||
| // JDK 1.8 is deprecated https://bugs.openjdk.org/browse/JDK-8173605 | |||
| // and now it requires -Xlint:-options to mute warnings about its deprecation | |||
| options.compilerArgs.add("-Xlint:-options") | |||
There was a problem hiding this comment.
Approach similar to one done within openJDK openjdk/jdk#10135
caicancai
reviewed
May 21, 2024
snuyanzin
force-pushed
the
jdk21
branch
4 times, most recently
from
50e29f5
to
784dfc6
Compare
yep, exactly, however the main test is ci since locally I have only one OS and on ci there are different |
|
I rebased the PR since gradle8 support was merged |
|
I will merge tomorrow if there is no objections |
Update dependencies asm from 7.2 to 9.6 byte-buddy from 1.9.3 to 1.14.15 forbiddenapis from 3.5.1 to 3.7 mockito from 2.23.4 to 3.12.4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds jdk21 and 22 to ci
The PR also adds deprecations to forbiddenAPI config for
URLconstructor which became deprecated since jdk20